Skip to content

add reusable TUI editor view#13817

Merged
harryalbert merged 4 commits into
masterfrom
harry/code-1822-generic-editor-view
Jul 17, 2026
Merged

add reusable TUI editor view#13817
harryalbert merged 4 commits into
masterfrom
harry/code-1822-generic-editor-view

Conversation

@harryalbert

@harryalbert harryalbert commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

harryalbert commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

@harryalbert harryalbert mentioned this pull request Jul 16, 2026
2 tasks
@harryalbert
harryalbert marked this pull request as ready for review July 16, 2026 11:48
@oz-for-oss

oz-for-oss Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR adds a reusable single-line TUI editor view and refactors TUI input/editor keybindings through a shared command table.

Concerns

  • The new reusable editor does not keep its char-cell viewport following the cursor after edits or movement, so long single-line content can disappear once it wraps beyond the first visible row.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread crates/warp_tui/src/editor_view.rs
@harryalbert
harryalbert requested a review from moirahuang July 16, 2026 11:59
@harryalbert
harryalbert force-pushed the harry/code-1822-generic-editor-view branch from a64da86 to db3a140 Compare July 16, 2026 12:44
@harryalbert
harryalbert force-pushed the harry/code-1822-focus-routing branch from 991c04e to 71a3e79 Compare July 16, 2026 12:44
@harryalbert
harryalbert force-pushed the harry/code-1822-generic-editor-view branch 2 times, most recently from 9ebd6fb to 159290e Compare July 16, 2026 13:56
Base automatically changed from harry/code-1822-focus-routing to master July 16, 2026 14:18
@harryalbert
harryalbert force-pushed the harry/code-1822-generic-editor-view branch from 159290e to 6d09be2 Compare July 16, 2026 14:19

@moirahuang moirahuang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for splitting up the PRs + adding the mermaid diagram! it made it way easier to review + the split between TuiInput and TuiEditor feels a lot more clean now

Comment thread crates/warp_tui/src/editor_element.rs Outdated
Comment thread crates/warp_tui/src/editor_view.rs
@harryalbert
harryalbert force-pushed the harry/code-1822-generic-editor-view branch from 6d09be2 to bc1a9f3 Compare July 16, 2026 22:12
@harryalbert harryalbert mentioned this pull request Jul 16, 2026
4 tasks
harryalbert and others added 3 commits July 16, 2026 22:17
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
@harryalbert
harryalbert force-pushed the harry/code-1822-generic-editor-view branch from 4e38b58 to 1c508d1 Compare July 17, 2026 02:57
@harryalbert
harryalbert enabled auto-merge (squash) July 17, 2026 03:03
@harryalbert
harryalbert merged commit 659cf37 into master Jul 17, 2026
26 checks passed
@harryalbert
harryalbert deleted the harry/code-1822-generic-editor-view branch July 17, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants