add reusable TUI editor view#13817
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR adds a reusable single-line TUI editor view and refactors TUI input/editor keybindings through a shared command table.
Concerns
- The new reusable editor does not keep its char-cell viewport following the cursor after edits or movement, so long single-line content can disappear once it wraps beyond the first visible row.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
a64da86 to
db3a140
Compare
991c04e to
71a3e79
Compare
9ebd6fb to
159290e
Compare
159290e to
6d09be2
Compare
moirahuang
left a comment
There was a problem hiding this comment.
thanks so much for splitting up the PRs + adding the mermaid diagram! it made it way easier to review + the split between TuiInput and TuiEditor feels a lot more clean now
6d09be2 to
bc1a9f3
Compare
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
4e38b58 to
1c508d1
Compare

Description
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Agent Mode