Update Loading and Failed Screens for Unsupported Block Editor#3573
Merged
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Contributor
|
Note: The "Build Android RN Bridge & Publish to S3" failure on CI is because pMz3w-diy-p2 got processed by Systems 5h ago which means S3 now returns 404 instead of 403 and we need to update our |
This commit corrects the reference to an "in-progress" screen to "failed".
AmandaRiu
approved these changes
Jun 29, 2021
Contributor
AmandaRiu
left a comment
AmandaRiu
left a comment
There was a problem hiding this comment.
Changes LGTM! Ready to merge once gutenberg is updated. 
This commit moves these changes from the "1.56.0" section of the notes to the "unreleased" section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Android side of #3425
gutenberg: WordPress/gutenberg#32395WordPress-Android: wordpress-mobile/WordPress-Android#14762WordPress-iOS: wordpress-mobile/WordPress-iOS#16586Description
The
/sites/{site_id}/gutenbergendpoint is unreliable but was being used to check if Gutenberg was available on a site's backend, and if so, disable the Unsupported Block Editor (UBE).Since the majority of users will have Gutenberg enabled, it makes sense to remove usage of this unreliable API endpoint. That's done in the Android PR in this PR chain.
To account for the removal, the loading and failed screens are updated in the Gutenberg PR.
How has this been tested?
Please refer to the Gutenberg PR as the central place for the most up-to-date testing instructions.
PR submission checklist: