Task and sim ctrl separation#102
Open
johnzhang3 wants to merge 11 commits intorai-opensource:mainfrom
Open
Conversation
- Add task_to_sim_ctrl() method to Task base class (default identity) - Update RolloutBackend to accept and use task_to_sim_ctrl function - Update MJSimulation to use task_to_sim_ctrl when setting controls - Update Controller to pass task.task_to_sim_ctrl to RolloutBackend - Tasks can now override task_to_sim_ctrl() to map between different control spaces
johnzhang3
requested review from
alberthli,
bhung-bdai,
jbruedigam-bdai,
pculbertson and
slecleach
as code owners
alberthli
approved these changes
Oct 31, 2025
Comment on lines
+3
to
+8
| ## Added | ||
| * Separation between task-space controls and MuJoCo simulation controls | ||
| * Added `task_to_sim_ctrl()` method to `Task` base class (default identity mapping) | ||
| * Updated `RolloutBackend` to accept and use `task_to_sim_ctrl` function for control mapping | ||
| * Updated `MJSimulation` to use `task_to_sim_ctrl` when setting controls | ||
| * Tasks can now override `task_to_sim_ctrl()` to map between different control spaces |
Collaborator
There was a problem hiding this comment.
tag yourself in these updates
slecleach
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.