Add cpp rollout and sim#88
Draft
jbruedigam-bdai wants to merge 1 commit intojbruedigam/generic_task_spacefrom
Draft
Add cpp rollout and sim#88jbruedigam-bdai wants to merge 1 commit intojbruedigam/generic_task_spacefrom
jbruedigam-bdai wants to merge 1 commit intojbruedigam/generic_task_spacefrom
Conversation
alberthli
reviewed
Sep 5, 2025
Collaborator
alberthli
left a comment
alberthli
left a comment
There was a problem hiding this comment.
Added a couple of comments on quick skim. If it's determined that this will be merged, I probably shouldn't be the one who approves, since a lot of the cpp code originated from me.
Comment on lines
+46
to
+47
| self.RolloutBackend = RolloutBackend | ||
| self.SimBackend = SimBackend |
Collaborator
There was a problem hiding this comment.
isn't this in the base task class? also, this file should be removed anyway before merging into main
Comment on lines
+14
to
+20
| def __init__(self, num_threads: int, backend: Literal["mujoco"], task_to_sim_ctrl: Callable) -> None: | ||
| """Initialize the backend with a number of threads.""" | ||
| self.backend = backend | ||
| if self.backend == "mujoco": | ||
| self.setup_mujoco_backend() | ||
| else: | ||
| raise ValueError(f"Unknown backend: {self.backend}") |
Collaborator
There was a problem hiding this comment.
we should probably combine this with the existing RolloutBackend infra and just add a new element to the Literal type that's like "mujoco_custom" or something
jbruedigam-bdai
force-pushed
the
jbruedigam/specialized_sim_rollout
branch
from
5e5cabe to
e945d19
Compare
jbruedigam-bdai
force-pushed
the
jbruedigam/specialized_sim_rollout
branch
from
e945d19 to
94d4399
Compare
johnzhang-rai
pushed a commit
to johnzhang3/judo
that referenced
this pull request
Oct 21, 2025
…project.toml and pixi.lock by taking upstream versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.