Add ability to fetch assets from an external git repository#96
Draft
bhung-bdai wants to merge 12 commits intorai-opensource:mainfrom
Draft
Add ability to fetch assets from an external git repository#96bhung-bdai wants to merge 12 commits intorai-opensource:mainfrom
bhung-bdai wants to merge 12 commits intorai-opensource:mainfrom
Conversation
alberthli
reviewed
Oct 29, 2025
Collaborator
alberthli
left a comment
alberthli
left a comment
There was a problem hiding this comment.
Thanks for this PR - much needed. I know it's still a draft, but besides the couple of comments below, here are additional considerations:
- We should definitely scrub all asset files from the commit history (xml, obj, stl, etc.). Not sure the best/safest way to do this, I usually use git filter repo for it, but want to 100% make sure we don't mess it up. This will also completely destabilize the commit history, and mess up all stacks/open PRs until they are rebased, so that's a consideration as well.
- Of course, you should set up the repository on the RAI side for asset hosting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to download and cache a source for assets external to the repo. This cleans up the codebase and allows hopefully easier import of different robot assets.