fix(pegboard): fix collecting metrics for actors without workflows#2519
Closed
Conversation
This was referenced Jun 2, 2025
Closed
Member
Author
This was referenced Jun 2, 2025
Deploying rivet with
|
| Latest commit: |
4527a1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e2bc9dc2.rivet.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-fix-colle.rivet.pages.dev |
Deploying rivet-hub with
|
| Latest commit: |
4527a1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3febe489.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-fix-colle.rivet-hub-7jb.pages.dev |
MasterPtato
force-pushed
the
05-31-fix_pegboard_fix_collecting_metrics_for_actors_without_workflows
branch
from
dff268d to
4527a1a
Compare
MasterPtato
force-pushed
the
05-31-feat_guard_add_http_ping_endpoint_to_edge_api_hosts
branch
from
64ab176 to
64361fd
Compare
Deploying rivet-studio with
|
| Latest commit: |
4527a1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35dede06.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-31-fix-pegboard-fix-colle.rivet-studio.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Improves error handling in pegboard_actor_get to handle actors without workflows, preventing complete function failure when collecting metrics. The function now gracefully handles WorkflowNotFound errors by skipping those actors and continuing with the remaining ones.
- Modified error handling around
sqlite_for_workflowto returnNoneinstead of failing when workflow is not found - Added specific error pattern matching for
WorkflowError::WorkflowNotFound - Ensures metrics collection continues for valid actors even when some workflows are missing
- Improves system resilience by handling completed/missing workflow scenarios
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 3, 2025
…2519) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
05-31-fix_pegboard_fix_collecting_metrics_for_actors_without_workflows
branch
This was referenced Jun 3, 2025
This was referenced Jun 4, 2025
Closed
This was referenced Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes