fix(pegboard): fix container runner orphaning#2575
Closed
MasterPtato wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 9, 2025
Closed
Closed
This was referenced Jun 9, 2025
Contributor
Author
MasterPtato
force-pushed
the
06-09-fix_pegboard_fix_container_runner_orphaning
branch
from
683f674 to
a25be6b
Compare
Deploying rivet with
|
| Latest commit: |
9a559a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4a1efa3.rivet.pages.dev |
| Branch Preview URL: | https://graphite-base-2532.rivet.pages.dev |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implements critical fixes to prevent container orphaning in the Pegboard system by improving container cleanup and adding parent process death handling.
- Modified container name format in
packages/edge/infra/client/manager/src/actor/setup.rsto include generation number ({actor_id}-{generation}) for precise container cleanup - Added PDEATHSIG configuration in
packages/edge/infra/client/container-runner/src/container.rsto ensure child containers are killed if parent process dies unexpectedly - Implemented pre-execution hooks for container processes using nix crate to handle parent death signals properly
2 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
719
to
723
| match Command::new("runc") | ||
| .arg("delete") | ||
| .arg("--force") | ||
| .arg(self.actor_id.to_string()) | ||
| .arg(format!("{}-{}", self.actor_id, self.generation)) | ||
| .output() |
There was a problem hiding this comment.
logic: Ensures correct container instance is deleted when multiple generations exist, preventing orphaned containers
NathanFlurry
approved these changes
Jun 9, 2025
MasterPtato
force-pushed
the
06-09-fix_pegboard_fix_container_runner_orphaning
branch
from
a25be6b to
9a559a0
Compare
This was referenced Jun 9, 2025
Deploying rivet-hub with
|
| Latest commit: |
9a559a0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7eb5cc72.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://graphite-base-2532.rivet-hub-7jb.pages.dev |
Deploying rivet-studio with
|
| Latest commit: |
9a559a0
|
| Status: | 🚫 Deploy failed. |
Contributor
Merge activity
|
graphite-app Bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
Bot
deleted the
06-09-fix_pegboard_fix_container_runner_orphaning
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes