Skip to content

fix: add create ts to server list#2523

Closed
MasterPtato wants to merge 1 commit into
mainfrom
06-03-fix_add_create_ts_to_server_list
Closed

fix: add create ts to server list#2523
MasterPtato wants to merge 1 commit into
mainfrom
06-03-fix_add_create_ts_to_server_list

Conversation

@MasterPtato

Copy link
Copy Markdown
Contributor

Changes

MasterPtato commented Jun 3, 2025

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds create_ts to server-related operations and improves metrics reporting accuracy, particularly focusing on CPU usage measurement in millicores.

  • Added create_ts field to ServerRow and Server structs with corresponding SQL query updates in get.rs, list.rs, and lost_list.rs
  • Changed CPU usage metric description from percent to millicores in pegboard/metrics.rs for accuracy
  • Improved actor state handling in pegboard/actor/get.rs with better error logging and optional row fetching
  • Removed incorrect CPU millicores to percentage conversion in usage metrics collection
  • Updated Grafana dashboard configurations by removing maxDataPoints constraints for better data granularity

10 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread packages/common/util/core/src/format.rs
Comment thread packages/common/util/core/src/format.rs
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 3, 2025

Copy link
Copy Markdown

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 863f139
Status: ✅  Deploy successful!
Preview URL: https://d2988443.rivet.pages.dev
Branch Preview URL: https://06-03-fix-add-create-ts-to-s.rivet.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 4, 2025

Copy link
Copy Markdown

Deploying rivet-studio with  Cloudflare Pages  Cloudflare Pages

Latest commit: 863f139
Status: ✅  Deploy successful!
Preview URL: https://c726546d.rivet-studio.pages.dev
Branch Preview URL: https://06-03-fix-add-create-ts-to-s.rivet-studio.pages.dev

View logs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 4, 2025

Copy link
Copy Markdown

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: 863f139
Status: ✅  Deploy successful!
Preview URL: https://de0a12f1.rivet-hub-7jb.pages.dev
Branch Preview URL: https://06-03-fix-add-create-ts-to-s.rivet-hub-7jb.pages.dev

View logs

@graphite-app

graphite-app Bot commented Jun 9, 2025

Copy link
Copy Markdown
Contributor

Merge activity

  • Jun 9, 4:46 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
  • Jun 9, 4:48 PM UTC: CI is running for this pull request on a draft pull request (#2574) due to your merge queue CI optimization settings.
  • Jun 9, 4:49 PM UTC: Merged by the Graphite merge queue via draft PR: #2574.

graphite-app Bot pushed a commit that referenced this pull request Jun 9, 2025
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app Bot closed this Jun 9, 2025
@graphite-app graphite-app Bot deleted the 06-03-fix_add_create_ts_to_server_list branch June 9, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant